Add TargetEncoder for scikit-learn - #384
Merged
Merged
Conversation
… add `infrequent_categories_` property
Avasam (Avasam)
approved these changes
Jun 20, 2025
Avasam (Avasam)
left a comment
Avasam (Avasam)
left a comment
Contributor
There was a problem hiding this comment.
Haven't runtime validated the ndarray. But I too a glance at the implementation and this LGTM.
Erik De Bonte (debonte)
approved these changes
Jun 20, 2025
Contributor
If you remove those 2 lines from the stubtest_allowlist.txt file, it'll be good to go! |
Contributor
|
Thanks for the contribution x99b! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#304
https://scikit-learn.org/stable/modules/generated/sklearn.preprocessing.TargetEncoder.html